search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 387 forks source link

[fixes #383] ensure every Exception inherits from KazooException #447

Closed Idem closed 7 years ago

Idem commented 7 years ago

Fixing #383

bbangert commented 7 years ago

@Idem Did you want to update this so I can merge it?

Idem commented 7 years ago

I was looking into the contributing guidelines and where into the process of signing the commits and co.

I obviously need to add the #noqa for hound and pass the travis-ci. So yes, I intend to clean this up a little more.

bbangert commented 7 years ago

I triggered the build by updating base just to ensure all the tests look good still.

bbangert commented 7 years ago

Just a heads-up, we're coming up on 30 days now. I'm trying to avoid having PR's idle eternally in the backlog like this, so if you'd like to try later, a new PR can be opened when ready. This is a fairly basic change, so I could clean it up and commit with the appropriate commit message if you'd like.

bbangert commented 7 years ago

@Idem Hi! I'd be happy to help with fixing the commit if you need any assistance. A good commit message for this would look like:

fix: ensure every exception inherits from KazooException

Closes #383

You could rebase this branch against master, amend the commit, then force-push to update the PR.

bbangert commented 7 years ago

Closing this for now, please re-open if/when you have time to update it.