search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 387 forks source link

Update Continuous Integration to ZooKeeper 3.5.3-beta #477

Closed tgockel closed 6 years ago

tgockel commented 7 years ago

Currently, .travis.yml uses the to-be-released ZOOKEEPER_VERSION=3.5.2-alpha. The current release (as of 2017-08-24) of the 3.5 line is 3.5.3-beta. Unless there is some motivation to continue to test against the old ZK server, .travis.yml should be updated to use the newer version.

jeffwidman commented 7 years ago

Great idea!

Pull request welcome if you want to update it. Otherwise I'll try to do it in the next week or so.

tgockel commented 7 years ago

So this is somewhat annoying...it seems that the file fetched in ensure-zookeeper-env will be zookeeper-3.5.3-beta.tar.gz. Despite the .tar.gz file suffix, it is actually a non-gzipped tarball, which makes the tar -zx fail. Changing this to tar -x works, but of course breaks all the properly-compressed files. Aside from opening a bug against ZK's packaging, I'm not sure what to here.

jeffwidman commented 7 years ago

Ugh, that's no fun.

Can you open a ticket on the Zookeeper Jira and link back to it here?

Generally I've found that team is reasonably responsive, especially to something like this which sounds like a very annoying packaging bug that is likely to bite a lot of folks.

tgockel commented 7 years ago

Bug is ZOOKEEPER-2885. Hopefully I'll get an email when it's fixed.

jeffwidman commented 7 years ago

Perfect, as long as you're a watcher on the JIRA ticket you'll get an email...

jeffwidman commented 7 years ago

@tgockel now that this is fixed upstream, do you want to submit a PR containing your commit that fixes this?

tgockel commented 7 years ago

It's marked as fixed, but the file hasn't propagated out to everywhere...there's some likelihood that it will not ever in a lot of mirrors, since people usually expect artifacts to be permanent.

jeffwidman commented 7 years ago

I assume from your comment that it's breaking on Travis still... That's a bummer. I guess we'll just have to wait for 3.5.4 to drop.

tgockel commented 7 years ago

Yeah...3.5.3 is beta anyway :-)