search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 387 forks source link

client: Allow SSL use when communicating with Zookeeper, fixes #382 #494

Closed emonty closed 6 years ago

emonty commented 6 years ago

Zookeeper 3.5 supports SSL for client communications, this commit adds support for it on the Kazoo side.

Note that you need to give the client the key, certificate and CA files.

Co-Authored-By: Monty Taylor mordred@inaugust.com

jeffwidman commented 6 years ago

Why the new PR when you already had #493? Are you aware that you can force push to your PR branch and GitHub will update your PR?

jeffwidman commented 6 years ago

nudge @emonty ^^

Shrews commented 6 years ago

@jeffwidman Pretty sure @emonty opened this one and closed the other so that he could grant permission to other folks to iterate on changes. In the other PR, only the original author (not us) could do that.

jeffwidman commented 6 years ago

@Shrews hmm, that's an interesting idea and I hadn't noticed they were different. However, no need for another PR, it's possible to flip that on/off using a checkbox on the original PR.

Thank you for reviewing the PR as well, always appreciate another set of eyes.

jeffwidman commented 6 years ago

Closing in favor of #513