search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 387 forks source link

Fix gevent 1.3b1+ timeout import #503

Closed carsonip closed 6 years ago

carsonip commented 6 years ago

gevent.event.Timeout is undocumented and will break when using gevent 1.3b1+. Use gevent.Timeout as suggested in gevent docs.

danmilon commented 6 years ago

got bitten by this too.

jeffwidman commented 6 years ago

This looks good. Can you update your commit message to the form fix: ... per the contributing guidelines?

https://github.com/python-zk/kazoo/blob/0905c47bff3cfc42382daff0d5ac81189c8ba46d/CONTRIBUTING.md#git-commit-guidelines

Once you do that, I'll happily merge.

carsonip commented 6 years ago

Just did a force push. Please check. Thanks.

dan-blanchard commented 6 years ago

gevent 1.3.0 is officially out now, so it would be really nice to have a release with this. I filed gevent/gevent#1205 because I was confused by this.

jeffwidman commented 6 years ago

Agreed, I don't currently have the ability to cut a release... see #502