fix(core): get_children with include_data=True uses GetChildren2 types

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.

https://kazoo.readthedocs.io

Apache License 2.0

1.3k stars 387 forks source link

fix(core): get_children with include_data=True uses GetChildren2 types #515

Closed saffroy closed 6 years ago

saffroy commented 6 years ago

Closes #514

jeffwidman commented 6 years ago

I am not sure why GitHub is now marking the branches as conflicting and requiring an update before merging... regardless I went ahead and updated and will merge via rebase which should drop the merge commit from the history. Just waiting on the tests to finish.

jeffwidman commented 6 years ago

@saffroy can you address the hound violation above? I personally don't see it as a blocker in this particular instance, but I don't have the permissions here to bypass it...

Please rebase to get rid of my merge commit and then I'll go ahead and merge this...

jeffwidman commented 6 years ago

nudge @saffroy