python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

fix(recipe): fix deprecation warning from threading.Event #657

Closed stefreak closed 2 years ago

stefreak commented 2 years ago

Fix deprecation warning emitted when calling threading.Event.isSet

Why is this needed?

Reasoning:

Proposed Changes

Does this PR introduce any breaking change?

stefreak commented 2 years ago

I'll be glad to rebase once #652 is merged. Just let me know if I overlook it :)

stefreak commented 2 years ago

@ceache sure, thanks a lot for the feedback! I have changed the commit message accordingly.

stefreak commented 2 years ago

I rebased with master, hoping that it would run the github actions for my PR, but it didn't; sorry for dismissing your reviews by doing that @ceache and @StephenSorriaux

StephenSorriaux commented 2 years ago

Sorry about that, that is actually on me. I will fix it.

StephenSorriaux commented 2 years ago

@stefreak Can you please rebase your PR with the current master that fixes the CI part? Thank you.

stefreak commented 2 years ago

@StephenSorriaux done :)

codecov-commenter commented 2 years ago

Codecov Report

Merging #657 (569c89c) into master (1ea097d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          56       56           
  Lines        8246     8246           
=======================================
  Hits         7768     7768           
  Misses        478      478           
Impacted Files Coverage Δ
kazoo/recipe/lock.py 97.95% <100.00%> (ø)
kazoo/recipe/queue.py 97.45% <100.00%> (ø)
kazoo/testing/harness.py 96.66% <100.00%> (ø)
kazoo/tests/test_lock.py 98.89% <100.00%> (ø)
kazoo/tests/test_connection.py 97.70% <0.00%> (-0.39%) :arrow_down:
kazoo/handlers/threading.py 91.94% <0.00%> (+0.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ea097d...569c89c. Read the comment docs.