python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.

https://kazoo.readthedocs.io

Apache License 2.0

1.3k stars 386 forks source link

chore: migrate to setup.cfg #666

Closed ceache closed 1 year ago

ceache commented 2 years ago

closes #644 #662 #663

Why is this needed?

Migrate to python packaging best practices.

Proposed Changes

use setup.cfg & pyproject.toml to build kazoo

Does this PR introduce any breaking change?

codecov-commenter commented 2 years ago

Codecov Report

Merging #666 (9ed34ce) into master (9bb8499) will decrease coverage by 0.01%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   94.47%   94.45%   -0.02%     
==========================================
  Files          57       57              
  Lines        8375     8368       -7     
==========================================
- Hits         7912     7904       -8     
- Misses        463      464       +1

Impacted Files	Coverage Δ
kazoo/tests/test_selectors_select.py	`95.00% <50.00%> (-2.02%)`	:arrow_down:
kazoo/recipe/barrier.py	`97.93% <0.00%> (-1.04%)`	:arrow_down:
kazoo/protocol/connection.py	`95.05% <0.00%> (ø)`
kazoo/tests/test_client.py	`98.80% <0.00%> (+0.09%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bb8499...9ed34ce. Read the comment docs.

StephenSorriaux commented 1 year ago

Hey @ceache

Really sorry for not having check this before :(

ceache commented 1 year ago

Wasn't in scope originally but I'll add it in a next PR

On Tue, Sep 20, 2022, 12:53 Stephen Sorriaux @.***> wrote:

@.**** approved this pull request.

Thank you!

In setup.cfg https://github.com/python-zk/kazoo/pull/666#discussion_r975606038:

+description = "Higher Level Zookeeper Client" +long_description = file: README.md, CHANGES.md +long_description_content_type = text/markdown +license = Apache 2.0 +license_file = LICENSE +platform = any +keywords = zookeeper, lock, leader, configuration +classifiers =

Development Status :: 5 - Production/Stable

License :: OSI Approved :: Apache Software License

Intended Audience :: Developers

Operating System :: OS Independent

Programming Language :: Python

Programming Language :: Python :: 3

Programming Language :: Python :: 3.7

Programming Language :: Python :: 3.8

is Python 3.9 missing?

— Reply to this email directly, view it on GitHub https://github.com/python-zk/kazoo/pull/666#pullrequestreview-1114174449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIFTHWG4BZHKRH6VZ3UG7LV7HTX5ANCNFSM5V6EOUAA . You are receiving this because you were mentioned.Message ID: @.***>