search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

Remove redundant wheel dep from pyproject.toml #671

Closed mgorny closed 1 year ago

mgorny commented 1 year ago

Why is this needed?

Remove the redundant wheel dependency, as it is added by the backend automatically. Listing it explicitly in the documentation was a historical mistake and has been fixed since, see: https://github.com/pypa/setuptools/commit/f7d30a9529378cf69054b5176249e5457aaf640a

Proposed Changes

Does this PR introduce any breaking change?

No.

codecov-commenter commented 1 year ago

Codecov Report

Base: 94.42% // Head: 94.53% // Increases project coverage by +0.10% :tada:

Coverage data is based on head (1d053fe) compared to base (bd62797). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #671 +/- ## ========================================== + Coverage 94.42% 94.53% +0.10% ========================================== Files 57 57 Lines 8399 8399 ========================================== + Hits 7931 7940 +9 + Misses 468 459 -9 ``` | [Impacted Files](https://codecov.io/gh/python-zk/kazoo/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk) | Coverage Δ | | |---|---|---| | [kazoo/tests/test\_client.py](https://codecov.io/gh/python-zk/kazoo/pull/671/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jbGllbnQucHk=) | `98.70% <0.00%> (-0.10%)` | :arrow_down: | | [kazoo/protocol/connection.py](https://codecov.io/gh/python-zk/kazoo/pull/671/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vcHJvdG9jb2wvY29ubmVjdGlvbi5weQ==) | `96.49% <0.00%> (+0.61%)` | :arrow_up: | | [kazoo/tests/test\_cache.py](https://codecov.io/gh/python-zk/kazoo/pull/671/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jYWNoZS5weQ==) | `59.86% <0.00%> (+2.38%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mgorny commented 1 year ago

Thanks!