Closed a-ungurianu closed 1 year ago
Base: 94.38% // Head: 94.67% // Increases project coverage by +0.29%
:tada:
Coverage data is based on head (
536007a
) compared to base (4b13135
). Patch coverage: 86.15% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for tackling this!
👍 from me other than a minor nitpick on syntax of reporting exception messages.
Gentle ping @ceache and @jeffwidman, would you like to give it a last look?
Any idea why isort take care of the import ordering/grouping?
I swear I saw isort errors in this repo. Maybe I confused it with some other one :)
@a-ungurianu Thank you again for this. I'll let you free to merge this whenever you want, and, if I am not mistaken, make it your first merge as an official Kazoo contributor :rocket:
Didn't realize I can press the big green button :). Here goes nothing
Thanks again for driving this to completion! Congrats on your first merge.
Fixes #677
Why is this needed?
Not "needed", but this removes unnecessary dependencies on
six
andselectors2
making this package a no-deps package for runtime usage.More of a spring cleaning
Proposed Changes
six
python3
stdlib updatesDoes this PR introduce any breaking change?
Should be completely backwards compatible. Exceptions might change a bit as we use
python3
'sraise ... from ...
syntax