python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

recipe(cache): Use protocol.paths.join instead of os.path.join #682

Closed a-ungurianu closed 1 year ago

a-ungurianu commented 1 year ago

Fixes #680

Why is this needed?

os.path.join doesWindows path joining on Windows resulting in bad zookeeper paths

Proposed Changes

Does this PR introduce any breaking change?

No.

codecov-commenter commented 1 year ago

Codecov Report

Base: 94.39% // Head: 94.33% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (7f2d9f2) compared to base (51b875a). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #682 +/- ## ========================================== - Coverage 94.39% 94.33% -0.07% ========================================== Files 57 57 Lines 8389 8388 -1 ========================================== - Hits 7919 7913 -6 - Misses 470 475 +5 ``` | [Impacted Files](https://codecov.io/gh/python-zk/kazoo/pull/682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk) | Coverage Δ | | |---|---|---| | [kazoo/recipe/cache.py](https://codecov.io/gh/python-zk/kazoo/pull/682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vcmVjaXBlL2NhY2hlLnB5) | `94.39% <100.00%> (-0.03%)` | :arrow_down: | | [kazoo/tests/test\_cache.py](https://codecov.io/gh/python-zk/kazoo/pull/682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jYWNoZS5weQ==) | `56.80% <0.00%> (-0.69%)` | :arrow_down: | | [kazoo/handlers/utils.py](https://codecov.io/gh/python-zk/kazoo/pull/682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vaGFuZGxlcnMvdXRpbHMucHk=) | `95.04% <0.00%> (-0.46%)` | :arrow_down: | | [kazoo/client.py](https://codecov.io/gh/python-zk/kazoo/pull/682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vY2xpZW50LnB5) | `98.09% <0.00%> (-0.32%)` | :arrow_down: | | [kazoo/protocol/connection.py](https://codecov.io/gh/python-zk/kazoo/pull/682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vcHJvdG9jb2wvY29ubmVjdGlvbi5weQ==) | `96.08% <0.00%> (-0.21%)` | :arrow_down: | | [kazoo/tests/test\_lock.py](https://codecov.io/gh/python-zk/kazoo/pull/682/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9sb2NrLnB5) | `99.13% <0.00%> (+0.17%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ceache commented 1 year ago

@a-ungurianu Do you mind rebasing instead of merging master? Makes for cleaner history

a-ungurianu commented 1 year ago

@a-ungurianu Do you mind rebasing instead of merging master? Makes for cleaner history

I agree. Fat fingered the GitHub UI (I think you can change the default in the repo settings somehow)

a-ungurianu commented 1 year ago

Redid the rebase