Closed a-ungurianu closed 1 year ago
Base: 94.39% // Head: 94.33% // Decreases project coverage by -0.06%
:warning:
Coverage data is based on head (
7f2d9f2
) compared to base (51b875a
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@a-ungurianu Do you mind rebasing instead of merging master? Makes for cleaner history
@a-ungurianu Do you mind rebasing instead of merging master? Makes for cleaner history
I agree. Fat fingered the GitHub UI (I think you can change the default in the repo settings somehow)
Redid the rebase
Fixes #680
Why is this needed?
os.path.join
doesWindows path joining on Windows resulting in bad zookeeper pathsProposed Changes
kazoo.protocol.paths
instead ofos.path.join
.Does this PR introduce any breaking change?
No.