Closed bringhurst closed 1 year ago
Note that py was also removed as a dependency from pytest. See https://github.com/pytest-dev/pytest/commit/19dda7c9bdc8ef71c792e0f77a9595bfad8d9248
Base: 94.67% // Head: 94.65% // Decreases project coverage by -0.03%
:warning:
Coverage data is based on head (
8febccd
) compared to base (f71da5f
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Note that the release.yml github actions workflow should probably be tested. I'm unsure on how to trigger that.
Hello,
Thank you for this.
The release.yml
workflow is only triggered from a tag, since it performs all the packaging and pypi upload stuff. Maybe we could add a package.yml
workflow where we do the packaging stuff without performing the final pypi upload. In any cases, I feel like it should not be part of this PR. I can look into it, unless you prefer/have time to do it.
After looking at it a bit more, I agree that it shouldn't be part of this PR.
I just put together a PR over at https://github.com/python-zk/kazoo/pull/692 to get that conversation going.
Going to merge as don't see a reason to hold off on this. Thanks @bringhurst !
Why is this needed?
tox-wheel is a deprecated package now that tox 4.x includes wheel support.
Example error message
When this issue occurs, you may see an error message similar to:
Proposed Changes
Does this PR introduce any breaking change?
No. Build time changes only.