python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

chore: migrate to tox 4.x #691

Closed bringhurst closed 1 year ago

bringhurst commented 1 year ago

Why is this needed?

tox-wheel is a deprecated package now that tox 4.x includes wheel support.

Example error message

When this issue occurs, you may see an error message similar to:

  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/tox_wheel/plugin.py", line 6, in <module>
    import py
ModuleNotFoundError: No module named 'py'
Error: Process completed with exit code 1.

Proposed Changes

Does this PR introduce any breaking change?

No. Build time changes only.

bringhurst commented 1 year ago

Note that py was also removed as a dependency from pytest. See https://github.com/pytest-dev/pytest/commit/19dda7c9bdc8ef71c792e0f77a9595bfad8d9248

codecov-commenter commented 1 year ago

Codecov Report

Base: 94.67% // Head: 94.65% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (8febccd) compared to base (f71da5f). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #691 +/- ## ========================================== - Coverage 94.67% 94.65% -0.03% ========================================== Files 56 57 +1 Lines 8338 8339 +1 ========================================== - Hits 7894 7893 -1 - Misses 444 446 +2 ``` | [Impacted Files](https://codecov.io/gh/python-zk/kazoo/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk) | Coverage Δ | | |---|---|---| | [kazoo/recipe/barrier.py](https://codecov.io/gh/python-zk/kazoo/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vcmVjaXBlL2JhcnJpZXIucHk=) | `98.96% <0.00%> (-1.04%)` | :arrow_down: | | [kazoo/protocol/connection.py](https://codecov.io/gh/python-zk/kazoo/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vcHJvdG9jb2wvY29ubmVjdGlvbi5weQ==) | `96.48% <0.00%> (-0.62%)` | :arrow_down: | | [kazoo/client.py](https://codecov.io/gh/python-zk/kazoo/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vY2xpZW50LnB5) | `98.40% <0.00%> (ø)` | | | [kazoo/\_\_init\_\_.py](https://codecov.io/gh/python-zk/kazoo/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | | | [kazoo/tests/test\_client.py](https://codecov.io/gh/python-zk/kazoo/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jbGllbnQucHk=) | `98.80% <0.00%> (+0.09%)` | :arrow_up: | | [kazoo/handlers/eventlet.py](https://codecov.io/gh/python-zk/kazoo/pull/691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vaGFuZGxlcnMvZXZlbnRsZXQucHk=) | `100.00% <0.00%> (+0.98%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bringhurst commented 1 year ago

Note that the release.yml github actions workflow should probably be tested. I'm unsure on how to trigger that.

StephenSorriaux commented 1 year ago

Hello,

Thank you for this.

The release.yml workflow is only triggered from a tag, since it performs all the packaging and pypi upload stuff. Maybe we could add a package.yml workflow where we do the packaging stuff without performing the final pypi upload. In any cases, I feel like it should not be part of this PR. I can look into it, unless you prefer/have time to do it.

bringhurst commented 1 year ago

After looking at it a bit more, I agree that it shouldn't be part of this PR.

I just put together a PR over at https://github.com/python-zk/kazoo/pull/692 to get that conversation going.

jeffwidman commented 1 year ago

Going to merge as don't see a reason to hold off on this. Thanks @bringhurst !