search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

Gate PR's so they require CI checks to pass #698

Open jeffwidman opened 1 year ago

jeffwidman commented 1 year ago

In https://github.com/python-zk/kazoo/pull/652, @StephenSorriaux very nicely fixed up our CI checks.

However, our current PR's aren't required to pass CI before being merged:

  1. We should change this so they have to pass CI.
  2. We need to retain the ability to override in case for some reason a PR intentionally won't pass CI but we still need to merge it. While very rare, this does occasionally happen. Several of the maintainers have admin rights on the repo so they could temporarily disable those branch checks if needed.
a-ungurianu commented 1 year ago

I agree with this, but I feel like fixing/ignoring the intermittent tests is a pre requisite for this

ceache commented 1 year ago

Agreed!

On Sat, Jan 21, 2023, 15:03 Jeff Widman @.***> wrote:

In #652 https://github.com/python-zk/kazoo/pull/652, @StephenSorriaux https://github.com/StephenSorriaux very nicely fixed up our CI checks.

However, our current PR's aren't required to pass CI before being merged:

  1. We should change this so they have to pass CI.
  2. We need to retain the ability to override in case for some reason a PR intentionally won't pass CI but we still need to merge it. While very rare, this does occasionally happen. That means at least one (preferably two) of the currently active maintainers should have admin rights on the repo so they could temporarily disable those branch checks if needed.

— Reply to this email directly, view it on GitHub https://github.com/python-zk/kazoo/issues/698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIFTHVSZ7ATKWJNIQQGP63WTQ6K3ANCNFSM6AAAAAAUCSCDS4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>