python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

No need to specify `mock` #702

Closed jeffwidman closed 1 year ago

jeffwidman commented 1 year ago

It's now part of the Python stdlib since 3.3.

So no need to specify it.

a-ungurianu commented 1 year ago

mock is indeed available in stdlib, but it's under unittest.mock

jeffwidman commented 1 year ago

Thanks @a-ungurianu, I threw this PR up quickly from web UI and then completely forgot about it!

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.63% // Head: 94.71% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (6d53733) compared to base (bcc9685). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 6d53733 differs from pull request most recent head 064fed0. Consider uploading reports for the commit 064fed0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #702 +/- ## ========================================== + Coverage 94.63% 94.71% +0.07% ========================================== Files 57 57 Lines 8339 8332 -7 ========================================== Hits 7892 7892 + Misses 447 440 -7 ``` | [Impacted Files](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk) | Coverage Δ | | |---|---|---| | [kazoo/tests/conftest.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvY29uZnRlc3QucHk=) | `100.00% <ø> (+62.50%)` | :arrow_up: | | [kazoo/tests/test\_\_connection.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9fY29ubmVjdGlvbi5weQ==) | `98.14% <100.00%> (+0.37%)` | :arrow_up: | | [kazoo/tests/test\_cache.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jYWNoZS5weQ==) | `59.18% <100.00%> (-0.35%)` | :arrow_down: | | [kazoo/tests/test\_client.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jbGllbnQucHk=) | `98.80% <100.00%> (+0.09%)` | :arrow_up: | | [kazoo/tests/test\_lock.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9sb2NrLnB5) | `98.78% <100.00%> (ø)` | | | [kazoo/tests/test\_partitioner.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9wYXJ0aXRpb25lci5weQ==) | `98.69% <100.00%> (ø)` | | | [kazoo/tests/test\_threading\_handler.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF90aHJlYWRpbmdfaGFuZGxlci5weQ==) | `96.18% <100.00%> (ø)` | | | [kazoo/tests/test\_utils.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF91dGlscy5weQ==) | `93.33% <100.00%> (ø)` | | | [kazoo/handlers/utils.py](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vaGFuZGxlcnMvdXRpbHMucHk=) | `94.06% <0.00%> (-0.46%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/python-zk/kazoo/pull/702?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jeffwidman commented 1 year ago

This is ready for review. The miniscule drop in coverage is a side effect of changing imports and shouldn't block merging.

jeffwidman commented 1 year ago

Can I please get a review on this so we can land it before merge conflicts creep in?