search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

debug: try bumping mock version #704

Closed jeffwidman closed 1 year ago

jeffwidman commented 1 year ago

Seeing a weird error in https://github.com/python-zk/kazoo/pull/702/ and wondering if it's because latest mock is actually 5.0.1: https://mock.readthedocs.io/en/latest/changelog.html

so threw this up to see what CI thinks

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.63% // Head: 94.42% // Decreases project coverage by -0.22% :warning:

Coverage data is based on head (ba1eb4f) compared to base (8f608f8). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #704 +/- ## ========================================== - Coverage 94.63% 94.42% -0.22% ========================================== Files 57 57 Lines 8339 8339 ========================================== - Hits 7892 7874 -18 - Misses 447 465 +18 ``` | [Impacted Files](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk) | Coverage Δ | | |---|---|---| | [kazoo/tests/test\_cache.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jYWNoZS5weQ==) | `55.10% <0.00%> (-4.09%)` | :arrow_down: | | [kazoo/tests/test\_eventlet\_handler.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9ldmVudGxldF9oYW5kbGVyLnB5) | `87.43% <0.00%> (-1.10%)` | :arrow_down: | | [kazoo/recipe/barrier.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vcmVjaXBlL2JhcnJpZXIucHk=) | `98.96% <0.00%> (-1.04%)` | :arrow_down: | | [kazoo/protocol/connection.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vcHJvdG9jb2wvY29ubmVjdGlvbi5weQ==) | `95.86% <0.00%> (-0.83%)` | :arrow_down: | | [kazoo/handlers/utils.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vaGFuZGxlcnMvdXRpbHMucHk=) | `94.06% <0.00%> (ø)` | | | [kazoo/tests/test\_client.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9jbGllbnQucHk=) | `98.80% <0.00%> (ø)` | | | [kazoo/tests/test\_gevent\_handler.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vdGVzdHMvdGVzdF9nZXZlbnRfaGFuZGxlci5weQ==) | `79.57% <0.00%> (ø)` | | | [kazoo/client.py](https://codecov.io/gh/python-zk/kazoo/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk#diff-a2F6b28vY2xpZW50LnB5) | `98.40% <0.00%> (+0.15%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-zk)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jeffwidman commented 1 year ago

Nope, the problem was in my grep'ing I only looked for import mock not from mock import... so missed some of the necessary import renames.