search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

Make the ReadTheDocs CI check a required check for PR's #712

Closed jeffwidman closed 1 year ago

jeffwidman commented 1 year ago

We should probably add [the ReadTheDocs CI check] as a mandatory check as we don't want broken docs :)

Originally posted by @a-ungurianu in https://github.com/python-zk/kazoo/pull/710#pullrequestreview-1304673640

jeffwidman commented 1 year ago

Good idea, I just made it required. If it turns out to be annoying down the road we can downlevel it to optional again.

While I was in there, I also flipped the "Choose which subset of outside collaborators will require approval to run workflows on their pull requests." to only folks new to GitHub... we don't have secrets we're trying to protect from being exposed via malicious PRs.

I also changed the permissions of GITHUB_TOKEN from read/write to only read... AFAIK we don't need write, but if that changes down the road we can re-up it.

Also I disabled the ability of GitHub actions to create/approve PR's on this repo... I don't think this disables Dependabot, and other than that we don't have actions that create/modify PRs.

Again, none of this is set in stone, just seemed like reasonable choices for our defaults for now, but no objections to anyone changing it if needed.