Closed nkormakov closed 7 months ago
Hello,
Thank you for the issue. Indeed the ZSESSIONCLOSEDREQUIRESASLAUTH
error (-124) is not handled properly (reminds me of a PR where @ztzg said some errors were not handled at all in the lib).
Some documentation for reference: https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md?plain=1#L1615
Hi Stephen!
What is the proper way of handling it will be? I'm aware that my workaround is not up to standards yet, but it does not produces some secondary errors or halts
We need to add a new error definition, at the very least. This is easy.
What we were referring to, with @ztzg, was better handling of unknown errors, this is much more comprehensive work.
Your monkey patch seems fine to me as a workaround for now. What are you asking exactly?
On Wed, Aug 9, 2023, 07:58 nkormakov @.***> wrote:
Hi Stephen!
What is the proper way of handling it will be? I'm aware that my workaround is not up to standards yet, but it does not produces some secondary errors or halts
— Reply to this email directly, view it on GitHub https://github.com/python-zk/kazoo/issues/727#issuecomment-1671191318, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIFTHRJZXBKMN7E6R2B7ADXUN3N7ANCNFSM6AAAAAA3ISBRDM . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Ok, I'll look into that and make a PR for you to judge.
Fixed by #743
Expected Behavior
No error, connection should be closed.
Actual Behavior
RuntimeError: Invalid error code
Snippet to Reproduce the Problem
It is happening when zookeeper running with a few extra jvm parameters
Default library doesn't handle well error code -124 which declares that client should authorise himself. Our application is ok with closing connection altogether and not messing with it. I've fixed it with monkey patching:
Logs with logging in DEBUG mode
Specifications
pip list
command: kazoo only