search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

fix(core): Add missing Zookeeper exceptions codes #743

Closed ceache closed 7 months ago

ceache commented 7 months ago

Sync'd up to Zookeeper 3.9.2 error codes.

Why is this needed?

Server errors with missing error codes are handled poorly and result in connection close.

Proposed Changes

Does this PR introduce any breaking change?

No.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (55f27b2) 96.76% compared to head (4c6bad8) 96.84%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #743 +/- ## ========================================== + Coverage 96.76% 96.84% +0.07% ========================================== Files 27 27 Lines 3557 3549 -8 ========================================== - Hits 3442 3437 -5 + Misses 115 112 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StephenSorriaux commented 7 months ago

Nice! Does this relate to #727?

ceache commented 7 months ago

@StephenSorriaux yes! It does resolve #727