search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

asyncio support #746

Closed takeda closed 6 months ago

takeda commented 6 months ago

What would you like to be added

Support to use Kazoo in asyncio based python code.

Why is this needed

AsyncIO became a first class citizen in python ecosystem and more and more applications are written with it in mind. It would be great if Kazoo could support it as well, especially that it does allow async commands already.

StephenSorriaux commented 6 months ago

Hello,

Thank you for the issue.

Like you said, I think this would be a very nice addition too. An attempt has been made with https://github.com/python-zk/kazoo/pull/646 but, on my side, I am not very familiar developing for asyncio (I am just an user of this API) so I was not able to know if the proposed changes were the way to go and did not feel comfortable giving any feedback.

I can take some time to study how we should/could do it but if anyone in @python-zk/maintainers have some experiences developing for asyncio please feel free to shim in! If you have any opinion about the proposed changes or some time to made a PR for this feature, please also feel free to do so!

StephenSorriaux commented 6 months ago

Closing as duplicate of https://github.com/python-zk/kazoo/issues/185

jeffwidman commented 6 months ago

Closing using reason "duplicate" rather than reason "complete"... @StephenSorriaux not sure if you've seen but this is a nifty new feature GitHub offers and makes it quicker to skim issues in search results etc. 🎉

StephenSorriaux commented 5 months ago

@jeffwidman I didn't notice, thank you for the tips!