python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

fix(core): Proper retry count in KazooRetry #748

Closed ceache closed 1 month ago

ceache commented 5 months ago

Make sure the number of attempts matches the max_retry parameter. Add unit tests to that effect.

Why is this needed?

So that users can precisely control the number of retries

Proposed Changes

Does this PR introduce any breaking change?

No, it shouldn't.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.01%. Comparing base (2fb93a8) to head (73309b2). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #748 +/- ## ========================================== + Coverage 96.81% 97.01% +0.19% ========================================== Files 27 27 Lines 3549 3549 ========================================== + Hits 3436 3443 +7 + Misses 113 106 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.