search

python-zk / kazoo

Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.
https://kazoo.readthedocs.io
Apache License 2.0
1.3k stars 386 forks source link

Added support for SNI #755

Closed jessesightler-redhat closed 1 month ago

jessesightler-redhat commented 2 months ago

Fixes #754

Why is this needed?

Supports SNI

Proposed Changes

Add server_hostname to the wrap call

Does this PR introduce any breaking change?

No

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.81%. Comparing base (2fb93a8) to head (7969318). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #755 +/- ## ======================================= Coverage 96.81% 96.81% ======================================= Files 27 27 Lines 3549 3553 +4 ======================================= + Hits 3436 3440 +4 Misses 113 113 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jessesightler-redhat commented 2 months ago

Formatting issues have been resolved. I'm not sure why one of the pypi tests failed with a segfault when all of the others passed.

jessesightler-redhat commented 2 months ago

@StephenSorriaux Thank you for the feedback. I have made several tweaks based upon your comments. Please let me know if you see any additional things that need attention.

ceache commented 1 month ago

@StephenSorriaux I believe you wanted to handle the squash & merge?