python / asyncio

asyncio historical repository
https://docs.python.org/3/library/asyncio.html
1.04k stars 177 forks source link

Use staticmethod or module function when instance isn't referenced. #436

Closed JustinTArthur closed 7 years ago

JustinTArthur commented 7 years ago

I used staticmethods where I thought the taxonomy or overridability might be useful, or I didn't know.

Martiusweb commented 7 years ago

Hi,

Do you have a use case where overriding those functions is useful? Imho, since those functions and methods are private, and unless there is a good use case inside the codebase of asyncio, we shouldn't encourage someone to override them.

gvanrossum commented 7 years ago

This looks like a refactoring that accomplishes nothing except code churn. Let's not do this.