Closed 1st1 closed 7 years ago
@gvanrossum Are you OK with me merging this in 3.6 beta 2?
Yes, LGTM.
Thanks! Merged by hand in d4abdd505ff609b7a8799bc405bfe476898b20ae. I'll make a PyPI package for starttls soon. Hopefully, this PR is enough (my current understanding is that it should be).
This is the key modification of
sslproto.py
required to implement starttls. With this patch in place, we can implement starttls as an external package without copying/pasting ofsslproto.py
.The patch is super small and non-invasive, only adding an extra argument to
SSLProtocol.__init__
(everything insidesslproto.py
is an implementation detail of asyncio).