search

python / asyncio

asyncio historical repository
https://docs.python.org/3/library/asyncio.html
1.03k stars 178 forks source link

Change import statements to import only what's needed #468

Open denisra opened 7 years ago

denisra commented 7 years ago

Changed all the import statements in all modules in the examples directory to import only what is needed.

This fixes issue #464

1st1 commented 7 years ago

How about we do simple

import asyncio

at the top of each example? get_event_loop() should become asyncio.get_event_loop().

That's the style we recommend in Python documentation and use in asyncio code itself.

denisra commented 7 years ago

That makes sense. Let me fix that.

the-knights-who-say-ni commented 7 years ago

Hello, and thanks for your contribution!

Unfortunately we couldn't find an account corresponding to your GitHub username at bugs.python.org (b.p.o). If you don't already have an account at b.p.o, please create one and make sure to add your GitHub username. If you do already have an account at b.p.o then please go there and under "Your Details" add your GitHub username.

And in case you haven't already, please make sure to sign the PSF contributor agreement (CLA); we can't legally look at your contribution until you have signed the CLA.

Once you have done everything that's needed, please reply here and someone will verify everything is in order.

denisra commented 7 years ago

@1st1 Please let me know if you need me to change anything else.

@the-knights-who-say-ni This is my first contribution. I've just created my account at bugs.python.org and added my Github username to it. Please let me know if I missed anything.

brettcannon commented 7 years ago

Please ignore any label fiddling I do; you managed to find a bug with the @the-knights-who-say-ni bot.

@denisra do make sure to sign the CLA.

brettcannon commented 7 years ago

OK, bot is fixed; sorry about that.

denisra commented 7 years ago

@brettcannon I can also confirm that I've signed the CLA.

1st1 commented 7 years ago

@denisra I wonder if we could remove import asyncio.test_utils completely. This is an internal module, and has nothing to do with examples (which historically were just experiments with asyncio, while asyncio was in active development).

denisra commented 7 years ago

@1st1 is it ok if I create another issue and submit another PR for that, to keep things separated?

1st1 commented 7 years ago

@1st1 is it ok if I create another issue and submit another PR for that, to keep things separated?

OK, let's do that!