search

python / asyncio

asyncio historical repository
https://docs.python.org/3/library/asyncio.html
1.03k stars 178 forks source link

Fix stop_serving in proactor loop kill all listening servers #496

Open julien-duponchelle opened 7 years ago

julien-duponchelle commented 7 years ago

Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.

1st1 commented 7 years ago

LGTM. @asvetlov can you also take a look?

fafhrd91 commented 7 years ago

lgtm

asvetlov is not very active at the moment

1st1 commented 7 years ago

I can merge this PR, but would you be able to re-submit it to http://github.com/python/cpython with a link to this PR? This would make merging this easier for me.

julien-duponchelle commented 7 years ago

Yes of course I will do it tomorrow.

Le jeu. 2 mars 2017 à 23:14, Yury Selivanov notifications@github.com a écrit :

I can merge this PR, but would you be able to re-submit it to http://github.com/python/cpython https://github.com/python/cpython with a link to this PR? This would make merging this easier for me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/python/asyncio/pull/496#issuecomment-283799569, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVFXZkNrVTmNCSK3TgLWlP-43YwozhSks5rhz8qgaJpZM4MHtGW .

1st1 commented 7 years ago

Yes of course I will do it tomorrow.

Would you be able to do it sooner by any chance? 3.6.1 RC1 is going to be tagged tomorrow.

julien-duponchelle commented 7 years ago

PR opened: https://github.com/python/cpython/pull/431