search

python / buildmaster-config

Configuration for buildbot.python.org
https://buildbot.python.org/all/#/
30 stars 55 forks source link

Add `--disable-gil` test flag to Windows NoGIL builder #458

Closed itamaro closed 8 months ago

itamaro commented 8 months ago

since https://github.com/python/cpython/pull/113129 (part of https://github.com/python/cpython/issues/112984), we need to pass --disable-gil to rt.bat too

zooba commented 8 months ago

Not sure if this passes it to rt.bat or Tools\buildbot\test.bat, but if it's the latter, we'll need to update the test.bat script to pass it through.

itamaro commented 7 months ago

Not sure if this passes it to rt.bat or Tools\buildbot\test.bat, but if it's the latter, we'll need to update the test.bat script to pass it through.

based on my limited understanding of batch scripts, this would add the --disable-gil flag to regrtest_args, which would then be handed off to rt.bat here.

it does look like recent builds are now failing in a different way (many link.exe failures from test_peg_generator).