search

python / cherry-picker

🐍🍒⛏ Utility script for backporting/cherry-picking CPython changes from master into one of the maintenance branches.
Apache License 2.0
46 stars 38 forks source link

Consider switching from `toml` to `tomli` #59

Closed sobolevn closed 1 year ago

sobolevn commented 2 years ago

toml was last released on 02.11.2020: https://pypi.org/project/toml/#history There are multiple known bugs: https://github.com/uiri/toml/issues

Maintainer is not supporting their project: https://github.com/uiri/toml/issues/361

Multiple big projects like mypy, black, typeshed have already switched.

The transition seems to be rather simple: basically swap import toml with import tomli and use a proper encoding when calling loads.

Related: https://www.python.org/dev/peps/pep-0680/

If this is something you think should be done, I can send a PR.

hugovk commented 2 years ago

PEP 680 has been accepted and will be in Python 3.11 :tada:

I think it would be a good idea to switch from from toml to tomli, it will make it easier to switch to the stdlib tomllib at some point in the future.

DanielNoord commented 1 year ago

Sorry @sobolevn, I didn't notice the last sentence of your post. Not sure if you were already working on this, but I have created a PR which fixes this in #67.