search

python / cherry-picker

🐍🍒⛏ Utility script for backporting/cherry-picking CPython changes from master into one of the maintenance branches.
Apache License 2.0
46 stars 38 forks source link

Fix the tests #76

Closed Jackenmen closed 1 year ago

Jackenmen commented 1 year ago

The tests introduced by #39 and #43 turned out to be faulty after combining them with the changes from #35.

Any chance for a hacktoberfest-accepted label btw? :)

cpython-cla-bot[bot] commented 1 year ago

All commit authors signed the Contributor License Agreement.
CLA signed

Jackenmen commented 1 year ago

I already had CLA integration so I imagine that it just didn't yet know my new commit email. When trying to auth with GitHub I got an internal server error from CLA integration but it seems that the known emails for my GitHub account have still been updated by the CLA integration :thinking: Should I report this anywhere? Screenshot_20221004_122641*

hugovk commented 1 year ago

The CLA bot fork is at https://github.com/ambv/cla-bot, issues can go to https://github.com/edgedb/cla-bot

But the CLA bot is now happy (https://github.com/python/cherry-picker/pull/76#issuecomment-1266732428):

image