Open antocuni opened 1 year ago
I just had this problem while trying to run the WASI build using the script introduced by #112473, running make distclean
resolved the problem.
Seems to me that the check target should recommend distclean
instead of clean
for the reasons you've identified.
Do note I put the cleanup under distclean
because it was easiest. If someone is motivated enough they could potentially get it moved.
Do note I put the cleanup under
distclean
because it was easiest. If someone is motivated enough they could potentially get it moved.
I opened #112610 because I think having a more helpful suggestion would probably be enough to resolve confusion for the case I ran into (i.e. hinting the user towards the alternate target they need). I don't know if it would be better to move this cleanup to another target, but the suggestion text is an easy change.
Bug report
Bug description:
First, do a regular in-tree build:
Then, try to make an out-of-tree build:
Now, if you try to run a top-level
make clean
as suggested, it's not enough:(I also tried to
cd .. && make clean
). The problem seems to be thatcheck-clean-src
checks for the presence of the./python
binary, which is not removed bymake clean
: https://github.com/python/cpython/blob/982f1b7d6dc2f13b9607ce092e36e32972e3702c/debug/Makefile#L773-L785If I remove it manually, the out-of-tree make works as expected
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs