python / cpython

The Python programming language
https://www.python.org/
Other
60.06k stars 29.09k forks source link

Small fix for gdb/libpython.py docs #118438

Closed Andrej730 closed 2 weeks ago

Andrej730 commented 3 weeks ago

Just accidentally noticed that it was mentioning PyIntObject * type which is deprecated - replaced it with PyLongObject *. Also replaced "ob_ival" with "long_value" - similar field that's used in PyLongObjectPtr.proxyval.

cpython-cla-bot[bot] commented 3 weeks ago

All commit authors signed the Contributor License Agreement.
CLA signed

bedevere-app[bot] commented 3 weeks ago

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Eclips4 commented 3 weeks ago

We also should update this line: https://github.com/python/cpython/blob/4a5ad8469af9a6fc0ec1355eb203cc22bb4321d5/Tools/gdb/libpython.py#L870

Include/longobjrep.h -> Include/longinterpr.h

bedevere-bot commented 2 weeks ago

:warning::warning::warning: Buildbot failure :warning::warning::warning:

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.x has failed when building commit f8e088df2a87f613ee23ea4f6787f87d9196b9de.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1368/builds/894) and take a look at the build logs.
  4. Check if the failure is related to this commit (f8e088df2a87f613ee23ea4f6787f87d9196b9de) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1368/builds/894

Failed tests:

Failed subtests:

Summary of the results of the build (if available):

==

Click to see traceback logs ```python-traceback Traceback (most recent call last): File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 131, in test_free_reference self.assertIsNone(wr()) ~~~~~~~~~~~~~~~~~^^^^^^ AssertionError: is not None ```
Eclips4 commented 2 weeks ago

Buildbot failure unrelated; probably related to #118444