python / cpython

The Python programming language
https://www.python.org/
Other
60.06k stars 29.09k forks source link

gh-118201 - Disable the flaky POSIX test_confstr test on iOS #118452

Closed freakboy3742 closed 2 weeks ago

freakboy3742 commented 2 weeks ago

About 1 in 10 builds appear to be failing on iOS due to the test.test_posix.PosixTester.test_confstr test. The next buildbot run almost always passes, with no other changes.

For want of a real fix, this PR skips that test on iOS to avoid misleading test failures from the buildbot.

I agree this isn't a very satisfying "fix", but I've been unable to reproduce the issue locally. However, in defence of the fix: the feature that is failing doesn't have much utility on iOS. It's no help knowing where the POSIX standard utilities are located (which is what is returned by the value CS_PATH), because you can't invoke them anyway. The other common values passed to confstr() appear to be GNU C dependent (FreeBSD only documents CS_PATH).

There's also precedent for this approach - there's a couple of other tests in the suite that are skipped as being "flaky" under specific build conditions.

If this is merged, we can keep the underlying ticket open on the off chance that someone is affected by the issue, or is able to find a way to reproduce it.