search

python / cpython

The Python programming language
https://www.python.org
Other
62.75k stars 30.08k forks source link

pyrepl: Cursor behaviour during tab-completion #119257

Open danielhollas opened 4 months ago

danielhollas commented 4 months ago

Pressing the Left arrow after the completions are shown moves the cursor three positions to the left.

It turns out reader.pos2xy uses reader.screen and reader.screeninfo to compute the position in the screen. Both of these include the two lines with completions. However, reader.pos and reader.buffer only include the things actually typed by the user (i.e. the third line datetime.). This leads to the new cursor position calculation being faulty. We'll have to think more about how to fix this.

Originally posted by @lysnikolaou in https://github.com/python/cpython/issues/118877#issuecomment-2104840020

danielhollas commented 4 months ago

@lysnikolaou I've taken the liberty of creating the issue for your observation in #118877, I hope that is okay.

I believe I have a fix for this in #118939, in case you want to take a look. Thanks!

cfbolz commented 1 month ago

I just hit this bug too, here's a recording (just before the cursor jumped, I pressed left arrow): asciicast

danielhollas commented 1 month ago

@cfbolz thanks for confirming the issue! It would be great if you could test if #118939 solves the problem for you.