search

python / cpython

The Python programming language
https://www.python.org
Other
63.06k stars 30.2k forks source link

Fixes missing dependencies in Makefile #119538

Open Meiye-lj opened 4 months ago

Meiye-lj commented 4 months ago

Bug report

Bug description:

This Makefile fixes an issue in the cpython. Specifically, previously, any modifications of files like Modules/expat/*.c would not trigger a rebuild of Modules/expat/xmltok.o Makefile_fixed.zip . The Makefile fixes this by including them as additional dependencies.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

ned-deily commented 4 months ago

Thank you for reporting the issue. Makefile is a file generated from Makefile.pre.in by running the configure script and thus any changes to the Python source code would need to be against Makefile.pre.in. Moreover, submitting any changes as the entire modified file especially one wrapped as a .zip file is difficult to review. Please follow our workflow guidelines in the Python Developer's Guide and open a pull request on GitHub with your proposed changes to Makefile.pre.in and reference this issue. Thanks!

ned-deily commented 4 months ago

With @erlend-aasland's PRs merged, I think we should be done with this issue. Thanks for calling it to our attention!

erlend-aasland commented 4 days ago

Re-opening, since there are more missing dependencies.