Closed sobolevn closed 2 months ago
ah this is because apple gcc is alias of clang, we should exclude macOS case. I will submit the patch today.
ah this is because apple gcc is alias of clang, we should exclude macOS case. I will submit the patch today.
I was wondering if simply using the fourth argument of AX_CHECK_COMPILE_FLAG
to include -Werror
would be a better solution than making the special case for apple gcc. That way any system compiling with clang would not include -Wtrampolines
and could remove the check for $CC
that wraps it:
AX_CHECK_COMPILE_FLAG([-Wtrampolines], [BASECFLAGS="$BASECFLAGS -Wtrampolines"], [AC_MSG_WARN([-Wtrampolines not supported])], [-Werror])
@nohlson You can submit the patch if you want!
@corona10 I will submit a patch that makes all these additions to BASEFLAGS
include -Werror
when checking for each flag.
@nohlson Please ping me once you submit the patch, we should run build bot too :)
@corona10 new PR https://github.com/python/cpython/pull/121030
Bug report
I am building CPython on macos 14.5, m2 chip, gcc:
I have lots of warnings like
Things I've tried:
make clean
main
Looks like https://github.com/python/cpython/pull/120975 is the cause. Please, note that buildbots of m1 workers also failed on this PR.
CC @nohlson @corona10
Linked PRs