search

python / cpython

The Python programming language
https://www.python.org
Other
62.33k stars 29.94k forks source link

Wrong binding of closure variable with intervening list comprehension #121377

Open limwz01 opened 2 months ago

limwz01 commented 2 months ago

Bug report

Bug description:

def f(x):
    def g():
        print([x for x in range(10)])
        def h():
            print(x)
        return h
    print(x)
    return g
f(1)()()

The above had always bound x in h to the parameter of f. But it no longer works and somehow binds to a local in g, throwing the following error:

NameError: cannot access free variable 'x' where it is not associated with a value in enclosing scope

CPython versions tested on:

3.12

Operating systems tested on:

Linux, Windows

gaogaotiantian commented 2 months ago

This is probably related to PEP 709 @carljm .

carljm commented 2 months ago

I've just moved house and am behind on everything, so it may be a bit before I can get to this, but I will fix it.

limwz01 commented 2 weeks ago

@carljm any updates?

carljm commented 2 weeks ago

I'm intending to work on this during the upcoming core dev sprint in September. If someone else gets to it first that's fine, though!