search

python / cpython

The Python programming language
https://www.python.org
Other
63.41k stars 30.37k forks source link

Windows Installer update with "keep current options" uninstalled the free-threaded binaries #124254

Open TBBle opened 1 month ago

TBBle commented 1 month ago

Bug report

Bug description:

I used the installer to upgrade from a Python 3.13.0rc1 install to a Python 3.13.0rc2 install. In the 3.13.0rc1 install, I had installed the free-threaded binaries.

When upgrading, I chose the first option, "Upgrade Now".

After the upgrade, the free-threaded binaries were no longer installed, and I had to rerun the installer and modify the install to add them.

Other non-default install options, such as installing the debug binaries, were not lost.

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs

zooba commented 1 month ago

Yeah, looks like it was missed from the list of features in the bootstrapper. It should only need to be added there.

We can fix it in 3.13.1. Anyone upgrading from RC will lose the setting, but that's okay. It's installed properly by 3.13.0 and so updates after that will be fine.