python / cpython

The Python programming language
https://www.python.org
Other
63.59k stars 30.47k forks source link

Wasi + Emscripten: configure behavior with --enable-optimizations seems incorrect? #126748

Open hoodmane opened 1 week ago

hoodmane commented 1 week ago

configure.ac sets DEF_MAKE_ALL_RULE to:

build_wasm is a modified version of the build_all target that drops some targets that don't build correctly in webassembly targets or are unneeded. This logic hasn't been added for the case when --enable-optimizations is passed. I think the best solution for now would be to check for these targets with --enable-optimizations and error out. I don't think PGO will work on the wasm targets without tinkering either way.

Linked PRs

brettcannon commented 1 week ago

I agree that erroring out if WASI or Emscripten is selected is best.