search

python / cpython

The Python programming language
https://www.python.org
Other
63.59k stars 30.46k forks source link

Fix for broken xml #127142

Closed smurav closed 1 hour ago

smurav commented 8 hours ago

Fix for broken xml

Structure of PCBuild/_freeze_module.vcxproj.filters was fixed.
cpython-cla-bot[bot] commented 8 hours ago

All commit authors signed the Contributor License Agreement.
CLA signed

bedevere-app[bot] commented 8 hours ago

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

smurav commented 7 hours ago

How can i add labels?

gh pr edit 127142 --add-label "skip issue" GraphQL: smurav does not have the correct permissions to execute AddLabelsToLabelable (addLabelsToLabelable)

ZeroIntensity commented 4 hours ago

How can i add labels?

You can't, just ping someone with the permissions and they can adjust it for you.

FWIW, this needs a NEWS entry, as build is technically user facing.

smurav commented 4 hours ago

Thanks @ZeroIntensity. Сan you add "skip news" label too?

ZeroIntensity commented 4 hours ago

Eh, alright. We do have a blurb section for build, but judging by it having one entry, I don't think we use it much. Hopefully a core dev won't yell at me for adding that :)

zooba commented 1 hour ago

This doesn't actually affect build in any way - the filters file is just the structure displayed in Visual Studio (which doesn't necessarily have to be filesystem layout for C/C++).