python / cpython

The Python programming language
https://www.python.org/
Other
60.06k stars 29.08k forks source link

clean up warnings in Win32 build of mmapmodule.c #32454

Closed bdaf8532-ded6-4d4c-9bb3-51fd76040dc1 closed 23 years ago

bdaf8532-ded6-4d4c-9bb3-51fd76040dc1 commented 23 years ago
BPO 400613
Nosy @tim-one
Files
  • None: None
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = [] title = 'clean up warnings in Win32 build of mmapmodule.c' updated_at = user = 'https://bugs.python.org/tmick' ``` bugs.python.org fields: ```python activity = actor = 'tim.peters' assignee = 'tmick' closed = True closed_date = None closer = None components = ['None'] creation = creator = 'tmick' dependencies = [] files = ['2461'] hgrepos = [] issue_num = 400613 keywords = ['patch'] message_count = 4.0 messages = ['32815', '32816', '32817', '32818'] nosy_count = 2.0 nosy_names = ['tim.peters', 'tmick'] pr_nums = [] priority = 'normal' resolution = None stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue400613' versions = [] ```

    bdaf8532-ded6-4d4c-9bb3-51fd76040dc1 commented 23 years ago
    tim-one commented 23 years ago

    Cool. Accepted & assigned back to Trent.

    bdaf8532-ded6-4d4c-9bb3-51fd76040dc1 commented 23 years ago

    I confirm that, to the best of my knowledge and belief, this contribution is free of any claims of third parties under copyright, patent or other rights or interests ("claims"). To the extent that I have any such claims, I hereby grant to CNRI a nonexclusive, irrevocable, royalty-free, worldwide license to reproduce, distribute, perform and/or display publicly, prepare derivative versions, and otherwise use this contribution as part of the Python software and its related documentation, or any derivative versions thereof, at no cost to CNRI or its licensed users, and to authorize others to do so.

    I acknowledge that CNRI may, at its sole discretion, decide whether or not to incorporate this contribution in the Python software and its related documentation. I further grant CNRI permission to use my name and other identifying information provided to CNRI by me for use in connection with the Python software and its related documentation.

    bdaf8532-ded6-4d4c-9bb3-51fd76040dc1 commented 23 years ago

    Fix a few warnings in the Win32 build of mmapmodule.c. The warnings were about comparison of singed (int) and unsigned (size_t) values. This was patched by casting every int to size_t for comparison. This is safe because every cast is preceded with a check guaranteeing that the int is positive.