python / cpython

The Python programming language
https://www.python.org/
Other
60.06k stars 29.09k forks source link

Doc strings added by Nils Fischbeck #32458

Closed gvanrossum closed 23 years ago

gvanrossum commented 23 years ago
BPO 400638
Nosy @gvanrossum
Files
  • None: None
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = 'https://github.com/gvanrossum' closed_at = created_at = labels = [] title = 'Doc strings added by Nils Fischbeck' updated_at = user = 'https://github.com/gvanrossum' ``` bugs.python.org fields: ```python activity = actor = 'gvanrossum' assignee = 'gvanrossum' closed = True closed_date = None closer = None components = ['None'] creation = creator = 'gvanrossum' dependencies = [] files = ['2465'] hgrepos = [] issue_num = 400638 keywords = ['patch'] message_count = 6.0 messages = ['32834', '32835', '32836', '32837', '32838', '32839'] nosy_count = 2.0 nosy_names = ['gvanrossum', 'effbot'] pr_nums = [] priority = 'normal' resolution = None stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue400638' versions = [] ```

    gvanrossum commented 23 years ago
    gvanrossum commented 23 years ago

    Nils writes: "I've finished to document the Tkinter-module. It is based on version 1.138. Martin von Loewis has reviewed it. Please check it in if you like."

    I like it, but I have no time to review it in detail. 1.138 is currently the latest so this should be easy to apply (in fact I uploaded the Tkinter.py file instead of a diff because it's probably smaller).

    gvanrossum commented 23 years ago

    I wish effbot could review this.

    gvanrossum commented 23 years ago

    Fredrik, can you see if there are any factual errors in these doc strings?

    Also, can you comment on possibly expected performance issues?

    gvanrossum commented 23 years ago

    Fredrik, go finish SRE first. I'll check this in, you can fix things after the b1 release.

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago

    I'll take a look as soon as SRE is checked in...