python / cpython

The Python programming language
https://www.python.org/
Other
60k stars 29.04k forks source link

SRE: towards 1.6b1 #32474

Closed b7a711ff-d634-47b2-ad1b-41e5ae806c8b closed 23 years ago

b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago
BPO 400657
Nosy @gvanrossum
Files
  • None: None
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = None closed_at = created_at = labels = [] title = 'SRE: towards 1.6b1' updated_at = user = 'https://bugs.python.org/effbot' ``` bugs.python.org fields: ```python activity = actor = 'gvanrossum' assignee = 'effbot' closed = True closed_date = None closer = None components = ['None'] creation = creator = 'effbot' dependencies = [] files = ['2480'] hgrepos = [] issue_num = 400657 keywords = ['patch'] message_count = 6.0 messages = ['32905', '32906', '32907', '32908', '32909', '32910'] nosy_count = 2.0 nosy_names = ['gvanrossum', 'effbot'] pr_nums = [] priority = 'normal' resolution = None stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue400657' versions = [] ```

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago
    gvanrossum commented 23 years ago

    (Note that the uploaded patch was missing sre_constants.h, at least.)

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago

    Oops, got a little carried away here :-)

    There are still a few things on my 1.6b1 laundry list (in addition to the list of "well-known but hopefully not critical engine bugs").

    Expect an updated patch within 2-3 hours. (but if anyone really wants to check this one in, please go ahead. It's definitely an improvement over what's in the repository right now).

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago

    This revision is a bit better. It messes up on repeated groups (they tend to come out empty), and there seems to be some issues with split and findall.

    And sub/subn are incredibly slow...

    And it's still called 'sre'. And there's no test suite.

    But except from that, it's not too bad. Check it in, try replacing 're' with 'sre' in some of your own code, and see what happens.

    I'll be back with sub/subn/split/findall fixes in a few hours.

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago

    Here's the last revision for today. There are a few annoying bugs left (including split, findall with groups, verbose patterns), but I really need to get some sleep...

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago

    I finally managed to get ssh working on my box, so I checked this one in myself.

    Andrews, can you close it for me?