search

python / cpython

The Python programming language
https://www.python.org/
Other
60.02k stars 29.05k forks source link

Fix -Wall-warnings in socket, classobject.c and object.c #32527

Closed Yhg1s closed 23 years ago

Yhg1s commented 23 years ago
BPO 400749
Nosy @malemburg, @Yhg1s, @smontanaro
Files
  • None: None
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = 'https://github.com/smontanaro' closed_at = created_at = labels = [] title = 'Fix -Wall-warnings in socket, classobject.c and object.c' updated_at = user = 'https://github.com/Yhg1s' ``` bugs.python.org fields: ```python activity = actor = 'effbot' assignee = 'skip.montanaro' closed = True closed_date = None closer = None components = ['None'] creation = creator = 'twouters' dependencies = [] files = ['2533'] hgrepos = [] issue_num = 400749 keywords = ['patch'] message_count = 6.0 messages = ['33079', '33080', '33081', '33082', '33083', '33084'] nosy_count = 4.0 nosy_names = ['lemburg', 'effbot', 'twouters', 'skip.montanaro'] pr_nums = [] priority = 'normal' resolution = None stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue400749' versions = [] ```

    Yhg1s commented 23 years ago
    Yhg1s commented 23 years ago

    Fixes a couple of the gcc -Wall warnings, those in classobject.c and object.c, and those in socketmodule.c when compiling with SSL support. Mostly removal of unused code, plus an appropriately placed #ifdef.

    Yhg1s commented 23 years ago

    Last two hunks updated. Shouldn't have failed, except for some offset, but it was a CVS diff -- it requires GNU patch 2.5 with 'POSIXLY_CORRECT' set, as environment variable. If you don't set it, it can't find files in different directories. This patch only touches one directory, though, so it should apply cleanly if applied inside Objects/

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago

    Checked in by Skip (who probably came up with the same patches himself, since he didn't close the patch).

    b7a711ff-d634-47b2-ad1b-41e5ae806c8b commented 23 years ago

    Checked in by Skip (who probably came up with the same patches himself, since he didn't close the patch).

    malemburg commented 23 years ago

    Please resubmit... the patch doesn't apply cleanly. I've only checked in the first hunk of the socketmodule.c patch.