python / cpython

The Python programming language
https://www.python.org/
Other
60k stars 29.04k forks source link

Fink Patch for Python 2.2 #35728

Closed 73ab2dc5-6ecd-41e8-b6bc-386fe5cb6a36 closed 22 years ago

73ab2dc5-6ecd-41e8-b6bc-386fe5cb6a36 commented 22 years ago
BPO 492301
Nosy @gvanrossum, @jackjansen
Files
  • python-unstable-2.2b2-2.patch: Python 2.2b2 patch for Mac OS X
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = 'https://github.com/jackjansen' closed_at = created_at = labels = ['OS-mac'] title = 'Fink Patch for Python 2.2' updated_at = user = 'https://bugs.python.org/sburrious' ``` bugs.python.org fields: ```python activity = actor = 'jackjansen' assignee = 'jackjansen' closed = True closed_date = None closer = None components = ['macOS'] creation = creator = 'sburrious' dependencies = [] files = ['3840'] hgrepos = [] issue_num = 492301 keywords = ['patch'] message_count = 4.0 messages = ['38459', '38460', '38461', '38462'] nosy_count = 3.0 nosy_names = ['gvanrossum', 'jackjansen', 'sburrious'] pr_nums = [] priority = 'normal' resolution = 'rejected' stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue492301' versions = [] ```

    73ab2dc5-6ecd-41e8-b6bc-386fe5cb6a36 commented 22 years ago

    Patch applied to Fink distribution of Python.

    Requested by Jack Jansen.

    gvanrossum commented 22 years ago

    Logged In: YES user_id=6380

    (Just curious - what kind of file format is this?)

    73ab2dc5-6ecd-41e8-b6bc-386fe5cb6a36 commented 22 years ago

    Logged In: YES user_id=322368

    I didn't prepare the patch, but I think it's the "unified" format for diff files.

    This particular patch is used by "fink," a command line tool for automating the installation of open source software, including the Unix version of Python, on Mac OS X.

    jackjansen commented 22 years ago

    Logged In: YES user_id=45365

    Steve, I'm afraid I can't accept these patches as-is. There's a couple of problems with them (aside from the file format, what is it, MacBinary? AppleSingle?). Also, I think most of the issues, except the /sw one, which should probably be fink-specific anyway, are solved with the current cvs tree. If not please let me know.

    The patch the the $(PGEN) line in Makefile.pre.in will not work, the LDFLAGS are specifically for Python itself, they may contain stuff for creating a framework, etc. The CPPFLAGS patch is probably fink-specific, the \<PREFIX> syntaxt I haven't seen before.

    The /sw convention in setup.py looks interesting, but I'm not sure whether this is a fink-only thing.

    The configure patch should be to configure.in (which is the sourcefile), and moreover I don't agree with it. Removing -ltermcap unconditionally will break builds on other platforms, which do need termcap.