python / cpython

The Python programming language
https://www.python.org
Other
63.1k stars 30.22k forks source link

USE_CACHE_ALIGNED still helpful? #36185

Closed tim-one closed 22 years ago

tim-one commented 22 years ago
BPO 524062
Nosy @tim-one, @jackjansen

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = 'https://github.com/jackjansen' closed_at = created_at = labels = ['interpreter-core'] title = 'USE_CACHE_ALIGNED still helpful?' updated_at = user = 'https://github.com/tim-one' ``` bugs.python.org fields: ```python activity = actor = 'tim.peters' assignee = 'jackjansen' closed = True closed_date = None closer = None components = ['Interpreter Core'] creation = creator = 'tim.peters' dependencies = [] files = [] hgrepos = [] issue_num = 524062 keywords = [] message_count = 3.0 messages = ['9465', '9466', '9467'] nosy_count = 2.0 nosy_names = ['tim.peters', 'jackjansen'] pr_nums = [] priority = 'normal' resolution = 'fixed' stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue524062' versions = [] ```

tim-one commented 22 years ago

Jack asked for this report:

""" MacPython uses it. At the time it was put in it caused a 15% increase in Pystones because dictionary entries were aligned in cache lines. But: this was in the PPC 601 and 604 era, I must say that I've never tested whether it made any difference on G3 and G4.

Put in a bug report in my name, and one day I'll get around to testing whether it still makes a difference on current hardware and rip it out if it doesn't. """

jackjansen commented 22 years ago

Logged In: YES user_id=45365

As MacPython normally uses the standard MSL malloc nowadays (and will probably use pymalloc in the future) the benefit of USE_CACHE_ALIGNED has disappeared. I've removed it.

tim-one commented 22 years ago

Logged In: YES user_id=31435

Since Jack removed this moldy old symbol, closing this as Fixed.