python / cpython

The Python programming language
https://www.python.org/
Other
60.91k stars 29.4k forks source link

expat doesn't build on MacOS9 #37912

Closed jackjansen closed 21 years ago

jackjansen commented 21 years ago
BPO 680797
Nosy @freddrake, @jackjansen

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = 'https://github.com/freddrake' closed_at = created_at = labels = ['extension-modules'] title = "expat doesn't build on MacOS9" updated_at = user = 'https://github.com/jackjansen' ``` bugs.python.org fields: ```python activity = actor = 'fdrake' assignee = 'fdrake' closed = True closed_date = None closer = None components = ['Extension Modules'] creation = creator = 'jackjansen' dependencies = [] files = [] hgrepos = [] issue_num = 680797 keywords = [] message_count = 3.0 messages = ['14457', '14458', '14459'] nosy_count = 3.0 nosy_names = ['fdrake', 'nnorwitz', 'jackjansen'] pr_nums = [] priority = 'normal' resolution = 'fixed' stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue680797' versions = [] ```

jackjansen commented 21 years ago

Expat doesn't build anymore on Mac OS 9. The problem is that the new expat.h has a couple of functions returning an "enum XML_Status", but that enum is declared only further down in expat.h and the Metrowerks compiler chokes on this.

It's easy enough to fix (either moving the routines down or moving the enum declaration up), but as I seem to recall that this file is imported from the expat distribution I'm not sure whether that's a good idea, or something else needs to be done.

d21744ff-f396-4c71-955e-7dbd2e886779 commented 21 years ago

Logged In: YES user_id=33168

Fred can you look at this since Martin is on vacation? I'm also not sure if this is part of expat or pyexpat (or how to tell).

freddrake commented 21 years ago

Logged In: YES user_id=3066

This is a known bug in Expat 1.95.6 that affects some compilers and not others (it even varies across versions of GCC). This has been fix in Expat's CVS repository; I've committed the same change to Python's CVS as Modules/expat/expat.h revision 1.5 (1.51 in Expat's CVS).