python / cpython

The Python programming language
https://www.python.org
Other
63.17k stars 30.25k forks source link

Tix.Grid patch #43675

Closed b9565901-0bfb-48b6-9a9c-573d75538313 closed 15 years ago

b9565901-0bfb-48b6-9a9c-573d75538313 commented 18 years ago
BPO 1522587
Nosy @loewis, @mkiever
Files
  • patch_tix.txt: against 46691
  • revised_1522587.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields: ```python assignee = 'https://github.com/loewis' closed_at = created_at = labels = ['type-feature', 'expert-tkinter'] title = 'Tix.Grid patch' updated_at = user = 'https://bugs.python.org/klappnase' ``` bugs.python.org fields: ```python activity = actor = 'gpolo' assignee = 'loewis' closed = True closed_date = closer = 'gpolo' components = ['Tkinter'] creation = creator = 'klappnase' dependencies = [] files = ['7405', '14396'] hgrepos = [] issue_num = 1522587 keywords = ['patch'] message_count = 6.0 messages = ['50699', '89580', '89887', '89888', '91690', '91706'] nosy_count = 4.0 nosy_names = ['loewis', 'mkiever', 'klappnase', 'gpolo'] pr_nums = [] priority = 'normal' resolution = 'fixed' stage = 'test needed' status = 'closed' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue1522587' versions = ['Python 3.1', 'Python 2.7'] ```

    b9565901-0bfb-48b6-9a9c-573d75538313 commented 18 years ago

    This patch fixes some issues with the newly added Tix.Grid widget:

    -added methods:

    I also added some (hopefully useful) docstrings.

    1fecb825-97ee-46b6-913c-bb07e2a288a6 commented 15 years ago

    Weird.. I guess no one ever used Tix.Grid ?

    1fecb825-97ee-46b6-913c-bb07e2a288a6 commented 15 years ago

    I've reviewed it now and produced a patch based on it, but it doesn't include undocumented Tix features that were added.

    I'm separating this new patch into two parts, the first part isn't supposed to affect Tix users, so it should be safe to commit. The second part is just a minor change in Tix.Grid.entrycget which adds a '-' before an option name (.diff not attached).

    There are also problems regarding xview/yview, but I decided to not fix them here. I expect to solve this in bpo-1135.

    1fecb825-97ee-46b6-913c-bb07e2a288a6 commented 15 years ago

    I forgot to include the new Grid constants, but I'm ok on adding them.

    1fecb825-97ee-46b6-913c-bb07e2a288a6 commented 15 years ago

    New constants and methods have been commited on r74510. I've added only the tix commands that are actually supported by tix.

    The fixes for some of the methods have been committed on r74511.

    1fecb825-97ee-46b6-913c-bb07e2a288a6 commented 15 years ago

    py3k branch: r74518.