python / cpython

The Python programming language
https://www.python.org
Other
62.36k stars 29.95k forks source link

Tools/msi/msi.py does not work with PCBuild8 #45678

Closed ea534ff9-6565-40f4-8398-d59320859a28 closed 16 years ago

ea534ff9-6565-40f4-8398-d59320859a28 commented 16 years ago
BPO 1337
Nosy @loewis, @tiran

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = 'https://github.com/loewis' closed_at = created_at = labels = ['type-feature', 'build'] title = 'Tools/msi/msi.py does not work with PCBuild8' updated_at = user = 'https://bugs.python.org/kevinwatters' ``` bugs.python.org fields: ```python activity = actor = 'christian.heimes' assignee = 'loewis' closed = True closed_date = closer = 'christian.heimes' components = ['Build'] creation = creator = 'kevinwatters' dependencies = [] files = [] hgrepos = [] issue_num = 1337 keywords = [] message_count = 5.0 messages = ['56791', '57239', '57621', '57665', '58740'] nosy_count = 3.0 nosy_names = ['loewis', 'christian.heimes', 'kevinwatters'] pr_nums = [] priority = 'low' resolution = 'out of date' stage = None status = 'closed' superseder = None type = 'enhancement' url = 'https://bugs.python.org/issue1337' versions = ['Python 2.6', 'Python 3.0'] ```

ea534ff9-6565-40f4-8398-d59320859a28 commented 16 years ago

The msi.py script for creating an Windows MSI installer from a Python source tree has hardcoded values for "PCBuild." The newer MSVC 2005 build directory is "PCBuild8" and has a slightly different structure.

msi.py needs to be changed to be able to work with a 2005-built Python tree as well.

tiran commented 16 years ago

PCBuild is still the default compiler for Python but any patches are appreciated. You could start by writing a new or updating the old compiler command to support VS 2005. The old distutils.msvccompiler supports only MSVC 6 and 7 but not 8.

61337411-43fc-4a9c-b8d5-4060aede66d0 commented 16 years ago

kevinwatters: don't bother fixing msi.py. I'll update it whenever I make a release; there is little point in updating it in-between.

tiran commented 16 years ago

Just for your information, Kevin:

I've created a PCbuild9 directory for VS 2008 Beta 2 in the py3k branch. I've also changed msi.py to work with PCbuild and PCbuild9.

tiran commented 16 years ago

Python 2.6 and 3.0 are using PCbuild9.