search

python / cpython

The Python programming language
https://www.python.org
Other
63.5k stars 30.42k forks source link

errors from msync ignored in mmap_object_dealloc #46896

Closed b510eab9-9bb7-4789-a06f-c0a1898e20d3 closed 13 years ago

b510eab9-9bb7-4789-a06f-c0a1898e20d3 commented 16 years ago
BPO 2644
Nosy @briancurtin

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = None closed_at = created_at = labels = ['type-bug'] title = 'errors from msync ignored in mmap_object_dealloc' updated_at = user = 'https://bugs.python.org/schmir' ``` bugs.python.org fields: ```python activity = actor = 'brian.curtin' assignee = 'none' closed = True closed_date = closer = 'brian.curtin' components = [] creation = creator = 'schmir' dependencies = [] files = [] hgrepos = [] issue_num = 2644 keywords = [] message_count = 5.0 messages = ['65553', '97573', '97583', '126414', '126433'] nosy_count = 3.0 nosy_names = ['schmir', 'brian.curtin', 'rosslagerwall'] pr_nums = [] priority = 'normal' resolution = 'out of date' stage = 'resolved' status = 'closed' superseder = None type = 'behavior' url = 'https://bugs.python.org/issue2644' versions = ['Python 2.6'] ```

b510eab9-9bb7-4789-a06f-c0a1898e20d3 commented 16 years ago

mmapmodule.c's mmap_object_dealloc calls msync without checking for an error.

briancurtin commented 14 years ago

Do you have a test case to reproduce the errors?

I see that we call msync followed by munmap, neither one checked.

b510eab9-9bb7-4789-a06f-c0a1898e20d3 commented 14 years ago

No, I don't know how to provoke such an error other than passing illegal parameters..(or munmap'ing the mmap'ed area).

a04be92c-af4e-4c3d-ab01-017f3a697ce8 commented 13 years ago

I think this can be closed.

msync() is only called in mmap.flush() and it is checked for an error.

briancurtin commented 13 years ago

That was changed in r84950 from bpo-2643.