Closed brettcannon closed 14 years ago
There is carbon-specific code in binhex. It really should go so that the module is completely platform-independent. This is especially pertinent for 3.0 as all Mac-specific modules are slated to go.
Have you read that code? The Carbon-specific code in there is needed to make the module behave correctly in OSX: the Carbon specific code is used to get and set some Mac-specific file attributes.
It should be easy enough to move that code into a small C extensions though, that way binhex will no longer depent on the Carbon python package.
On Sat, May 3, 2008 at 1:36 AM, Ronald Oussoren \report@bugs.python.org\ wrote:
Ronald Oussoren \ronaldoussoren@mac.com\ added the comment:
Have you read that code?
Not in detail, no.
The Carbon-specific code in there is needed to make the module behave correctly in OSX: the Carbon specific code is used to get and set some Mac-specific file attributes.
It should be easy enough to move that code into a small C extensions though, that way binhex will no longer depent on the Carbon python package.
OK.
This came up again recently in bpo-6621.
What's the current status of the binhex module in py3k? It looks as though the Carbon-specific code has been *partially* but not completely removed. In particular, there are references to FSSpec remaining, but no FSSpec is imported anywhere.
The references to FSSpec are all inside "if os.name == 'mac': ... " blocks. On my 10.5/Intel and 10.4/PPC systems os.name gives 'posix', so these blocks never get executed.
Is it safe to simply remove these blocks?
From my understanding the mac platform is OS 9, so that code in those 'if' blocks can go.
Thanks, Brett. I've removed those blocks in r74289 (py3k) and r74290 (release31-maint).
It looks to me as though this issue can now be closed. Ronald, any comments?
I would close this, but I am not sure what the resolution should be.
Closing as fixed.
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields: ```python assignee = None closed_at =
created_at =
labels = ['type-bug', 'library']
title = 'Remove carbon-specific code from binhex'
updated_at =
user = 'https://github.com/brettcannon'
```
bugs.python.org fields:
```python
activity =
actor = 'mark.dickinson'
assignee = 'none'
closed = True
closed_date =
closer = 'mark.dickinson'
components = ['Library (Lib)']
creation =
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 2715
keywords = []
message_count = 9.0
messages = ['65947', '66150', '66166', '91193', '91195', '91201', '91202', '104542', '104547']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'terry.reedy', 'ronaldoussoren', 'mark.dickinson']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2715'
versions = ['Python 2.6']
```