python / cpython

The Python programming language
https://www.python.org/
Other
60.02k stars 29.05k forks source link

typo in Mac/Makefile.in breaks installing IDLE #47663

Closed efd54b2f-2106-478f-aa8c-13cab7280b31 closed 15 years ago

efd54b2f-2106-478f-aa8c-13cab7280b31 commented 15 years ago
BPO 3413
Nosy @benjaminp

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = None closed_at = created_at = labels = ['build'] title = 'typo in Mac/Makefile.in breaks installing IDLE' updated_at = user = 'https://bugs.python.org/erickt' ``` bugs.python.org fields: ```python activity = actor = 'benjamin.peterson' assignee = 'none' closed = True closed_date = closer = 'benjamin.peterson' components = ['Build'] creation = creator = 'erickt' dependencies = [] files = [] hgrepos = [] issue_num = 3413 keywords = [] message_count = 2.0 messages = ['70001', '70002'] nosy_count = 2.0 nosy_names = ['benjamin.peterson', 'erickt'] pr_nums = [] priority = 'normal' resolution = 'fixed' stage = None status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue3413' versions = ['Python 3.0'] ```

efd54b2f-2106-478f-aa8c-13cab7280b31 commented 15 years ago

There's a slight typo in Mac/Makefile.in, where DESDIR was used instead of DESTDIR. This patch fixes it:

--- /tmp/Makefile.in    2008-07-18 19:42:29.000000000 -0700
+++ Mac/Makefile.in 2008-07-18 19:42:33.000000000 -0700
@@ -216,7 +216,7 @@
    test -d "$(DESTDIR)$(PYTHONAPPSDIR)" || mkdir -p "$(DESTDIR)$(PYTHONAPPSDIR)"
    -test -d "$(DESTDIR)$(PYTHONAPPSDIR)/IDLE.app" && rm -r 
"$(DESTDIR)$(PYTHONAPPSDIR)/IDLE.app"
    cp -PR IDLE/IDLE.app "$(DESTDIR)$(PYTHONAPPSDIR)"
-   ln -sf $(INSTALLED_PYTHONAPP) 
"$(DESDIR)$(PYTHONAPPSDIR)/IDLE.app/Contents/MacOS/Python"
+   ln -sf $(INSTALLED_PYTHONAPP) 
"$(DESTDIR)$(PYTHONAPPSDIR)/IDLE.app/Contents/MacOS/Python"
    touch "$(DESTDIR)$(PYTHONAPPSDIR)/IDLE.app"

 $(INSTALLED_PYTHONAPP): install_Python
benjaminp commented 15 years ago

Thanks! Fixed in r65129.