search

python / cpython

The Python programming language
https://www.python.org
Other
63.84k stars 30.56k forks source link

build mode which fails for build failures in extensions #48554

Open doko42 opened 16 years ago

doko42 commented 16 years ago
BPO 4304
Nosy @doko42, @bitdancer, @encukou

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields: ```python assignee = None closed_at = None created_at = labels = ['build'] title = 'build mode which fails for build failures in extensions' updated_at = user = 'https://github.com/doko42' ``` bugs.python.org fields: ```python activity = actor = 'petr.viktorin' assignee = 'none' closed = False closed_date = None closer = None components = ['Build'] creation = creator = 'doko' dependencies = [] files = [] hgrepos = [] issue_num = 4304 keywords = ['buildbot'] message_count = 5.0 messages = ['75780', '109576', '109816', '189914', '404309'] nosy_count = 3.0 nosy_names = ['doko', 'r.david.murray', 'petr.viktorin'] pr_nums = [] priority = 'normal' resolution = None stage = None status = 'open' superseder = None type = None url = 'https://bugs.python.org/issue4304' versions = [] ```

doko42 commented 16 years ago

as seen in bpo-4303, the buildbots don't complain about build failures in extensions. it would be nice to have a mode, where the build fails when an extension doesn't build, but is expected to build. exceptions to this set of expected builds should be configurable.

83d2e70e-e599-4a04-b820-3814bbdb9bef commented 14 years ago

Would someone with knowledge of the buildbots like to comment please.

bitdancer commented 14 years ago

One reasonably easy possibility would be to add an option to regrtest to exit with a non-zero return code if there are unexpected skips. This might not cover 100% of Mathias's cases (but it might), and the configurability would be limited to changing the expected skip lists in regrtest. But it would be pretty easy to do, if all of the buildbots can be required to build all of the expected extensions. I'm not sure that this last requirement is currently met by all the buidbots.

83d2e70e-e599-4a04-b820-3814bbdb9bef commented 11 years ago

Can someone answer the question pointed to by msg109816 i.e. can all of the buildbots build all of the expected extensions?

encukou commented 3 years ago

This would be nice. Too often when hacking on an extension, test pass just because I don't notice there was a compile error and so I'm testing an older version.

iritkatriel commented 2 years ago

See also https://github.com/python/cpython/issues/50980.

merwok commented 2 years ago

@tiran could you say if the new build system avoids this problem?